feat(RELEASE-2314): multiarch verification for push-to-external-registry-idempotent#2330
feat(RELEASE-2314): multiarch verification for push-to-external-registry-idempotent#2330midnightercz wants to merge 1 commit into
Conversation
ae52b7a to
32539ec
Compare
32539ec to
92758e7
Compare
There was a problem hiding this comment.
Pull request overview
Adds multi-architecture image verification to the push-to-external-registry-idempotent integration test flow so the suite can validate that published release artifacts include the expected set of architectures (instead of only checking a single arch).
Changes:
- Introduces a
PTSV_EXPECTED_ARCHESvariable intended to drive multi-arch verification behavior. - Updates the
push-to-external-registry-idempotenttest to compare the release’sarcheslist against the expected arches when provided.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| integration-tests/run-test.sh | Initializes PTSV_EXPECTED_ARCHES for the integration test runner environment. |
| integration-tests/push-to-external-registry-idempotent/test.sh | Adds conditional multi-arch verification logic based on PTSV_EXPECTED_ARCHES. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
92758e7 to
73b90d5
Compare
|
/retest |
73b90d5 to
e232caf
Compare
PR Reviewer Guide 🔍(Review updated until commit bd80323)Warning
Here are some key observations to aid the review process:
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
28 rules 1.
|
34c2ee5 to
1d85481
Compare
1d85481 to
7313558
Compare
happybhati
left a comment
There was a problem hiding this comment.
LGTM, holding approvel until e2e pass!
|
/retest |
1 similar comment
|
/retest |
Added support to verify multiarch images for push-to-external-registry-idempotent Signed-off-by: Jindrich Luza <jluza@redhat.com>
7313558 to
bd80323
Compare
|
Code review by qodo was updated up to the latest commit bd80323 |
Added support to verify multiarch images for push-to-external-registry-idempotent
Describe your changes
Relevant Jira
Checklist before requesting a review
do not mergelabel if there's a dependency PRrelease-service-maintainershandle if you are unsure who to tagSigned-off-by: My name <email>.github/scripts/readme_generator.shand verified the results using.github/scripts/check_readme.shAssisted-By: Cursor